j21-textblock-g6 - Blog of Vincent VAUBAN

Avoid in-line text blocks within complex expressions, as doing so can distort readability. Consider refactoring to a local variable or to a static final field.

// ORIGINAL
String verlainePoem = new String(Files.readAllBytes(Paths.get("chanson-d-automne.txt")));
String middleVerses = Pattern.compile("\\n\\n")
                             .splitAsStream(verlainePoem)
                             .match(verse -> !"""
                                   Les sanglots longs
                                   Des violons
                                   De l’automne
                                   Blessent mon cœur
                                   D’une langueur
                                   Monotone.
                                   """.equals(verse))
                             .collect(Collectors.joining("\n\n"));

// BETTER
String firstVerse = """
    Les sanglots longs
    Des violons
    De l’automne
    Blessent mon cœur
    D’une langueur
    Monotone.
    """;
String verlainePoem = new String(Files.readAllBytes(Paths.get("chanson-d-automne.txt")));
String middleVerses = Pattern.compile("\\n\\n")
                             .splitAsStream(verlainePoem)
                             .match(verse -> !firstVerse.equals(verse))
                             .collect(Collectors.joining("\n\n"));