Return to site

Code review insights

Five Code Review Antipatterns by Trisha Gee

· video,coding

Here some common code review anti-patterns and their solutions:

NIT-PICKING

Use tool such as checkstyle to make sure style guidelines have been followed or to use sonarqube to identify common quality and security issues.

INCONSISTENT FEEDBACK

Define the priorities for your applications and your teams to fundamental questions like:

  • use of modern or classic style of Java?
  • O(1) or O(n) operations on data structures?

LAST-MINUTE DESIGN CHANGES

Spot the problem early thanks to

  • whiteboarding ideas,
  • pair-programming,
  •  talk with the techlead.

PING-PONG REVIEWS

Define when the review is done by

  • a task list of items to check or by
  • an empowered individual who close the review (senior developer, lead, architect)

GHOST REVIEWER

  • Keep review small
  • Define a clear scope for the review (no "find any possible issue with that code")
  • Allow time for code review in the development process
All Posts
×

Almost done…

We just sent you an email. Please click the link in the email to confirm your subscription!

OK